feat: Add Shift State Sensor #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, isn't an enum an input class in HA? |
|
I got it from the Sensor Dev site https://developers.home-assistant.io/docs/core/entity/sensor/ " |
|
Ok, does our minimum version of ha cover this sensor or would we need to increment it. It's the hacs.json. |
|
Looks like it was introduced in 2023.1.0 shall we bump the min version required? or remove the fancy enum stuff and just use a generic sensor? |
|
We can bump. |
|
Oh, can you please make the bump so I can merge this in? |
|
Bumped :) |
|
Thanks. But I thought you said it came in in 2023.1? The way to tell is finding the commit that brought it in. |
|
Right you are. Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a car Shift state ENUM sensor, so you can detect what gear the car is in specifically.
This is different to the Parking Break binary sensor, as you get the explicit gear.